fix(parser): handle $'...' ANSI-C quoting in parameter expansion patterns#856
Merged
fix(parser): handle $'...' ANSI-C quoting in parameter expansion patterns#856
Conversation
…erns
Add $'\n', $'\t', etc. support to parse_word so patterns in ${var%$'\n'}
are correctly expanded before matching. Also update chained_string_operations
test expectation since operand expansion now works correctly.
Closes #847
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${var%$'\n'}and other ANSI-C quoted patterns now work correctly in parameter expansion$'...'handling toparse_wordso escape sequences are resolved before pattern matching${var#$'\t'},${var%%$'\n'}, etc.chained_string_operationstest — removedbash_diffannotation since operand expansion now works correctlyTest plan
vop_suffix_removal_ansi_c_newline—${str%$'\n'}strips trailing newlinevop_suffix_removal_var_newline—${str%${nl}}strips trailing newline via variablechained_string_operations— now matches real bash behaviorCloses #847